This repository was archived by the owner on Jan 15, 2026. It is now read-only.
Add missing load statement for proto_library#68
Merged
alexeagle merged 1 commit intoaspect-build:mainfrom May 1, 2025
Merged
Conversation
Signed-off-by: Adin Cebic <[email protected]>
|
|
alexeagle
approved these changes
May 1, 2025
Member
alexeagle
left a comment
alexeagle
left a comment
There was a problem hiding this comment.
Thanks - I suspect we'll have to give up on this feature of creating libraries for the well-known-types but you're right this is better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated BUILD.bazel file does not contain required load statement for proto_library:
load("@rules_proto//proto:defs.bzl", "proto_library")which results in following error on bazel 8:
Not sure if this happens on earlier versions of bazel as this rule might have been vendored similar to rules_android and others.