Skip to content
This repository was archived by the owner on Jan 15, 2026. It is now read-only.

Fix download filename for RC versions#33

Closed
aaylward wants to merge 1 commit intoaspect-build:mainfrom
aaylward:main
Closed

Fix download filename for RC versions#33
aaylward wants to merge 1 commit intoaspect-build:mainfrom
aaylward:main

Conversation

@aaylward
Copy link
Contributor

@aaylward aaylward commented Nov 23, 2024 •
edited
Loading

fixes #32

What is this?

This PR fixes filename resolution for release candidate version of protoc. RC names like 29.0-rc3 have release artifacts with names like 29.0-rc-3.... see the release assets for 29.0-rc3 or 28.0-rc2

Changes are visible to end-users: no

Test plan

  • Pretty much covered by existing test cases with example protoc version changed to LATEST
  • Added unit test to validate release_version -> artifact_name against supported versions

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@aaylward aaylward force-pushed the main branch 2 times, most recently from fe9c70e to ad27af1 Compare November 26, 2024 02:02
@aaylward aaylward changed the title fix filename for rc versions Fix download filename for RC versions Nov 27, 2024
alexeagle
alexeagle reviewed Dec 6, 2024
View reviewed changes
alexeagle
alexeagle approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@alexeagle alexeagle mentioned this pull request Dec 6, 2024
Merged
@alexeagle
Copy link
Member

alexeagle commented Dec 6, 2024

Hm, I'm not able to push to your branch

To github.com:aaylward/toolchains_protoc.git
 ! [remote rejected] aaylward/main -> aaylward/main (permission denied)
error: failed to push some refs to 'github.com:aaylward/toolchains_protoc.git'

Will land in #37

@alexeagle alexeagle closed this Dec 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@alexeagle alexeagle alexeagle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Examples fail to build with v29.0-rc3 or LATEST (when LATEST is a release candidate)

3 participants

@aaylward @CLAassistant @alexeagle