Skip to content
This repository was archived by the owner on Jan 15, 2026. It is now read-only.

Fix compatibility with rules_proto 7#30

Merged
alexeagle merged 2 commits intoaspect-build:mainfrom
fmeum:rules_proto-7
Nov 14, 2024
Merged

Fix compatibility with rules_proto 7#30
alexeagle merged 2 commits intoaspect-build:mainfrom
fmeum:rules_proto-7

Conversation

@fmeum
Copy link
Contributor

@fmeum fmeum commented Nov 14, 2024


Changes are visible to end-users: no

Test plan

  • Manual testing; please provide instructions so we can reproduce: Bump rules_proto version to 7.0.2 and run tests.

@fmeum fmeum marked this pull request as ready for review November 14, 2024 10:46
Copy link
Member

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@alexeagle alexeagle merged commit 382ae8d into aspect-build:main Nov 14, 2024
@fmeum fmeum deleted the rules_proto-7 branch November 14, 2024 18:02
@fmeum
Copy link
Contributor Author

fmeum commented Nov 14, 2024

@alexeagle Could you cut a new release with this change? That would help make rules_go compatible with AEGs.

@alexeagle
Copy link
Member

To github.com:aspect-build/toolchains_protoc.git
 * [new tag]         v0.3.4 -> v0.3.4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants