ci(pre-commit): Autoupdate#474
Merged
alexeagle merged 2 commits intoaspect-build:mainfrom Dec 13, 2024
Merged
Conversation
alexeagle
reviewed
Dec 12, 2024
hofbi
commented
Dec 12, 2024
Contributor
Author
|
Interesting, the automerge was blocked until I resolved the last open conversation |
alexeagle
pushed a commit
that referenced
this pull request
Jan 23, 2025
Follow up of #474 running buildifier on all files. A follow up PR will fix the remaining `buildifier-lint` warnings and add pre-commit to CI similar to bazel-contrib/rules-template#130. Co-authored-by: Alex Eagle <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pre-commit hooks are quite old in this repo. This PR run
pre-commit autoupdate. Since the hooks are not enfored by CI, buildifier is already broken. I will create a follow up PR similar to bazel-contrib/bazel-lib#1002 that adds it to CI and fix all errors.