Skip to content

Fix js_test nodejs toolchain exec_group#2328

Closed
keith wants to merge 1 commit intoaspect-build:2.xfrom
keith:ks/fix-js_test-nodejs-toolchain-exec_group
Closed

Fix js_test nodejs toolchain exec_group#2328
keith wants to merge 1 commit intoaspect-build:2.xfrom
keith:ks/fix-js_test-nodejs-toolchain-exec_group

Conversation

@keith
Copy link
Copy Markdown
Contributor

@keith keith commented Aug 23, 2025

If you cross compile the js_test target, the nodejs toolchain needs to
be configured for the test exec group.

Depends on bazel-contrib/bazel_features#112

@keith
Fix js_test nodejs toolchain exec_group
a3031c0 
If you cross compile the js_test target, the nodejs toolchain needs to
be configured for the test exec group.

Depends on bazel-contrib/bazel_features#112
@aspect-workflows
Copy link
Copy Markdown

aspect-workflows bot commented Aug 23, 2025 •
edited
Loading

Test

⚠️ Buildkite build #9175 failed.

Test

e2e/bzlmod

⚠️ Buildkite build #9175 failed.

Test

e2e/gyp_no_install_script

⚠️ Buildkite build #9175 failed.

Test

e2e/js_image_oci

⚠️ Buildkite build #9175 failed.

Test

e2e/npm_link_package

Buildkite build #9175 is running...

Test

e2e/npm_link_package-esm

Buildkite build #9175 is running...

Test

e2e/npm_translate_lock

⚠️ Buildkite build #9175 failed.

Test

e2e/npm_translate_lock_empty

⚠️ Buildkite build #9175 failed.

Test

e2e/npm_translate_lock_multi

⚠️ Buildkite build #9175 failed.

Test

e2e/npm_translate_lock_partial_clone

⚠️ Buildkite build #9175 failed.

Test

e2e/npm_translate_lock_replace_packages

⚠️ Buildkite build #9175 failed.

Test

e2e/npm_translate_lock_subdir_patch

⚠️ Buildkite build #9175 failed.

Test

e2e/npm_translate_package_lock

⚠️ Buildkite build #9175 failed.

Test

e2e/npm_translate_yarn_lock

⚠️ Buildkite build #9175 failed.

Test

e2e/package_json_module

⚠️ Buildkite build #9175 failed.

Test

e2e/pnpm_lockfiles

⚠️ Buildkite build #9175 failed.

Test

e2e/pnpm_workspace

⚠️ Buildkite build #9175 failed.

Test

e2e/pnpm_workspace_rerooted

⚠️ Buildkite build #9175 failed.

Test

e2e/repo_mapping

⚠️ Buildkite build #9175 failed.

Test

e2e/rules_foo

Buildkite build #9175 is running...

Test

e2e/runfiles

⚠️ Buildkite build #9175 failed.

Test

e2e/vendored_node

Buildkite build #9175 is running...

Buildifier

Format

@keith
Copy link
Copy Markdown
Contributor Author

keith commented Aug 26, 2025

can be replaced by #2330 if it works

@keith keith mentioned this pull request Aug 26, 2025
Merged
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jan 23, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@keith
Copy link
Copy Markdown
Contributor Author

keith commented Mar 18, 2026

#2330

@keith keith closed this Mar 18, 2026
@keith keith deleted the ks/fix-js_test-nodejs-toolchain-exec_group branch March 18, 2026 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@keith @CLAassistant