feat: support version.axl and remove config.toml#935
Merged
Conversation
65de3ac to
642a108
Compare
Switch launcher config from TOML+serde+liquid to Starlark AST parsing.
The new format uses function-call syntax (version(), local(), github(),
http()) that is statically analyzable without full evaluation.
- Remove liquid and toml dependencies, add starlark_syntax
- Parse version.axl via AST walking instead of serde deserialization
- Use str::replace for http URL templates instead of liquid
- Derive github release/artifact defaults at runtime when omitted
Use positional version arg, rename release to tag, simplify template vars
- version() now takes version as first positional arg instead of use=
- github() uses tag instead of release field name
- Template variables simplified to {version}, {os}, {arch}, {target}
- {os} = kernel name (darwin, linux) from uname -s
- {arch} = ISA name (x86_64, aarch64) from uname -m
- {target} = GNU triple (aarch64-apple-darwin)
- Extract replace_vars() helper for consistent replacement
- Apply template replacement to github tag/artifact fields too
Create version.md
642a108 to
1962773
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes are visible to end-users: yes
Test plan
ASPECT_DEBUG=1 ./target/debug/aspectand observe the output.