Skip to content

Speed up by mypyc transpilation #51

Open

Description

@nstarman

Activity

  1. asmeurer commented on Sep 21, 2023

    @asmeurer
    Owner

    Is the performance bad? I would expect most of the time is spent in pyflakes. Maybe ruff can be used instead to provide a boost. Does it expose all the necessary information?

  2. nstarman commented on Sep 22, 2023

    @nstarman
    CollaboratorAuthor

    People at Astropy have noticed it's the slowest step in our pre-commit.

  3. nstarman commented on Sep 22, 2023

    @nstarman
    CollaboratorAuthor

    I'm not sure about ruff's python API. But that would presumably be much faster

  4. asmeurer commented on Sep 22, 2023

    @asmeurer
    Owner

    They don't have one yet, but using it as a subprocess may be fast enough. astral-sh/ruff#659

  5. asmeurer commented on Sep 22, 2023

    @asmeurer
    Owner

    Also would be a good idea to profile this to see if that actually is why it's slow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions