add 1764864000, remove 1730210400 #38
Conversation
jurraca
force-pushed
the
add-176486400
branch
from
b80b889 to
17f2e06
Compare
|
ACK 17f2e06, this matches my asmap.dat files. Aside: why delete the old map files? They keep using space in the repo anyway. |
|
It was more out of concern for people using out of date files. We don't want to encourage people to use old files outside of research purposes really, and "last 6 runs" seemed about right. Though good point on the repo size continually growing. The |
|
What would you think about creating a subdirectory per year, and putting the full asmap files only in there, and then only having the latest one in the root? |
|
I like it! and it would be nice to have all historical data in one place. I don't have a problem with the size of the repo being a few multiples larger than 30M either. @fjahr thoughts? |
i have checked that these match the files on commit 17f2e06. |
|
sha256sum matches. |
hodlinator
left a comment
hodlinator
left a comment
There was a problem hiding this comment.
ACK 17f2e06
₿ ./contrib/asmap/asmap-tool.py encode --fill ~/kartograf/out/1764864000/final_result.txt ~/kartograf/out/1764864000/1764864000_asmap.dat
₿ ./contrib/asmap/asmap-tool.py encode ~/kartograf/out/1764864000/final_result.txt ~/kartograf/out/1764864000/1764864000_asmap_unfilled.dat
₿ sha256sum ~/asmap-data/1764864000_asmap.dat ~/asmap-data/1764864000_asmap_unfilled.dat ~/asmap-data/latest_asmap.dat
05dd85e7a6eb183109fa301528cfc1dd2442938ca59c9b00e312327840ce4180 /home/hodlinator/asmap-data/1764864000_asmap.dat
d8cc45e194bc9cdebec72c665a3068148d4ea1b05ed6d16a5530a441a9cbc63f /home/hodlinator/asmap-data/1764864000_asmap_unfilled.dat
05dd85e7a6eb183109fa301528cfc1dd2442938ca59c9b00e312327840ce4180 /home/hodlinator/asmap-data/latest_asmap.dat
₿ sha256sum ~/kartograf/out/1764864000/1764864000_asmap.dat ~/kartograf/out/1764864000/1764864000_asmap_unfilled.dat
05dd85e7a6eb183109fa301528cfc1dd2442938ca59c9b00e312327840ce4180 /home/hodlinator/kartograf/out/1764864000/1764864000_asmap.dat
d8cc45e194bc9cdebec72c665a3068148d4ea1b05ed6d16a5530a441a9cbc63f /home/hodlinator/kartograf/out/1764864000/1764864000_asmap_unfilled.dat
nit: Also prefer moving to another directory over deletion since it should consume the same space in the repo, but not a dealbreaker.
|
ACK 17f2e06 Confirmed all the hashes match with my results. |
Sure, sounds good to me as well. Since we have been more consistent with the monthly runs I was planning to suggest keeping files for up to 12 months anyway once we had gotten rid of the old files that are not available with our new fille/unfilled pattern. But it shouldn't hurt to keep these available for easy access as well. Having them in yearly folders sound good to me too! |
e7e5195 contrib: Avoid outputting binary data to TTY (Hodlinator) Pull request description: Verify that we wouldn't be writing encoded asmap binary data directly to the TTY since it is the default but makes no sense. (Having stdout as default does make sense when piping to other applications however). Found while exploring the ASMap data pipeline (asmap/asmap-data#38 (review)) from Kartograf into Bitcoin Core. ACKs for top commit: fjahr: tACK e7e5195 sipa: ACK e7e5195 Tree-SHA512: e1ae1ee129715471cbb824268e68cec267d159d4073297af35c06eadfb6b98eeae040beaafeb6489c2853ea9b83cd04471bcd0b27f0ae8fcb377e6e10b4ae6c5
6 participants
This adds the
latest_asmap.datresult for the coordinated launch from #36 for epoch 176486400. We had a match from 10/13 participants in the coordinated launch.The sha256 hash after encoding the file are:
--fill) /latest_asmap.dat:05dd85e7a6eb183109fa301528cfc1dd2442938ca59c9b00e312327840ce4180 latest_asmap.datd8cc45e194bc9cdebec72c665a3068148d4ea1b05ed6d16a5530a441a9cbc63f 1764864000_asmap_unfilled.datTo confirm the result of the encoding you can use asmap-tool.
this also removes the oldest ASmap file
1730210400_asmap.dat(December 2024).Compared with the removed file from December 2024, the diff of ipv4 addresses was 8.2%.