Fix test issues: properly check mock expectations and improve log cap… #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ture - connection_test.go: Fix TestConnectionManagerMultipleConnections to properly check ExpectationsWereMet() errors instead of silently discarding them with blank identifiers - logging_test.go: Improve log output capture by also redirecting the standard log package output, and add proper error checking for empty output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ture
connection_test.go: Fix TestConnectionManagerMultipleConnections to properly check ExpectationsWereMet() errors instead of silently discarding them with blank identifiers
logging_test.go: Improve log output capture by also redirecting the standard log package output, and add proper error checking for empty output
Note
Tightens test robustness by checking sqlmock ExpectationsWereMet and capturing standard logger output in logging tests, while removing unused ping expectations.
cmd/mysql-mcp-server/connection_test.go):sqlmockexpectations via explicitExpectationsWereMet()checks (including multi-connection test).ExpectPing()expectations and related mock variables.cmd/mysql-mcp-server/logging_test.go):log.SetOutputduring tests and restore afterward.Written by Cursor Bugbot for commit 126f0c3. This will update automatically on new commits. Configure here.