Repository navigation
Conversation
|
@adity982 is attempting to deploy a commit to the Vam Gan's projects Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
Closing as already implemented on main in 0ce3fc3. Verified that this entire patch reverse-applies cleanly to current main, including pending abort, no-timeout, and listener-cleanup regressions. The current core suite also passes. No changes are being discarded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AbortSignalwhile resolving a context source even when no timeout is configuredWhy
runSourceTask()previously returned the source promise directly whenevertimeoutMswas omitted. That bypassed the abort listener entirely, so a pending source could keep an aborted request open indefinitely. The timeout and abort paths also did not consistently remove the listener.Fixes #376.
Validation
npm test --workspace @askable-ui/core -- src/__tests__/context.test.ts(131 passed)NODE_OPTIONS=--localstorage-file=... npm test --workspace @askable-ui/core(538 passed)npm run build --workspace @askable-ui/core(includes the@askable-ui/contextprebuild)git diff --check