Skip to content

fix(react): keep navigation source options current - #390

Merged
vamgan merged 1 commit into
mainfrom
fix/react-navigation-stale-closures
Jul 26, 2026
Merged

fix(react): keep navigation source options current#390
vamgan merged 1 commit into
mainfrom
fix/react-navigation-stale-closures

Conversation

@vamgan

@vamgan vamgan commented Jul 26, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • keep React navigation source callbacks and scalar options synchronized with committed router renders
  • preserve navigation history and one source registration when callbacks, kind, or maxHistory change
  • make core navigation sources read mutable options dynamically while retaining state-mode behavior
  • add React Router, Next.js, history-preservation, and suspended-render regressions

Testing

  • Core navigation source tests (11 passed)
  • React navigation source tests (10 passed)
  • Full workspace build
  • Full workspace test suite (1,167 passed)
  • TypeScript package builds and diff validation

Closes #373

@vercel

vercel Bot commented Jul 26, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
askable Ready Ready Preview, Comment Jul 26, 2026 6:02pm

@pkg-pr-new

pkg-pr-new Bot commented Jul 26, 2026

Copy link
Copy Markdown

Open in StackBlitz

@askable-ui/angular

npm i https://pkg.pr.new/@askable-ui/angular@390

@askable-ui/context

npm i https://pkg.pr.new/@askable-ui/context@390

@askable-ui/core

npm i https://pkg.pr.new/@askable-ui/core@390

@askable-ui/create-app

npm i https://pkg.pr.new/@askable-ui/create-app@390

@askable-ui/mcp

npm i https://pkg.pr.new/@askable-ui/mcp@390

@askable-ui/qwik

npm i https://pkg.pr.new/@askable-ui/qwik@390

@askable-ui/react

npm i https://pkg.pr.new/@askable-ui/react@390

@askable-ui/react-native

npm i https://pkg.pr.new/@askable-ui/react-native@390

@askable-ui/solid

npm i https://pkg.pr.new/@askable-ui/solid@390

@askable-ui/svelte

npm i https://pkg.pr.new/@askable-ui/svelte@390

@askable-ui/vue

npm i https://pkg.pr.new/@askable-ui/vue@390

@askable-ui/web-component

npm i https://pkg.pr.new/@askable-ui/web-component@390

commit: 7ed4671

@vamgan
vamgan merged commit e5535c2 into main Jul 26, 2026
9 checks passed
@vamgan
vamgan deleted the fix/react-navigation-stale-closures branch July 26, 2026 18:04

This branch was successfully deployed

1 active deployment
Preview — 7ed46715 Deployed Jul 26, 2026 by vercel[bot]
View deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug(react): navigation source resolves stale route closures

1 participant

@vamgan