Repository navigation
ci(dependabot): keep major dev-dependency updates out of the grouped PR - #355
Merged
Merged
Conversation
The dev-dependencies group bundled every dev update, including major version jumps — which is how an Angular 19->22 major (breaking the directive's change detection) ended up inside a routine grouped PR (#346). Restricting the group to minor/patch makes every major dev bump surface as its own standalone PR.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@askable-ui/angular
@askable-ui/context
@askable-ui/core
@askable-ui/create-app
@askable-ui/mcp
@askable-ui/qwik
@askable-ui/react
@askable-ui/react-native
@askable-ui/solid
@askable-ui/svelte
@askable-ui/vue
@askable-ui/web-component
commit: |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
dev-dependenciesDependabot group bundled every dev-dependency update, including major version jumps. That's how PR #346 ended up silently containing an Angular 19 → 22 major (pluszone.js,@analogjs/*, TypeScript 6) alongside routine bumps — and that Angular major breaks the directive's change detection.Fix
Restrict the group to
minor+patch:Now every major dev bump surfaces as its own standalone PR (clearly a major, reviewed on its own), while safe minor/patch updates still group together. This is generic — it protects against any future breaking major hidden in the group, not just Angular.
Follow-up
Once this is merged, #346 should be closed — Dependabot will regenerate the grouped PR (minor/patch only) on its next run, and the Angular major will come as a separate PR that can be handled deliberately (it needs zoneless-safe change-detection work in the Angular directive).
Test plan
dependabot.ymlis valid YAML🤖 Generated with Claude Code
Generated by Claude Code