Install with no arguments#45
Merged
gigabo merged 1 commit intoasini:masterfrom Oct 25, 2016
Merged
Conversation
Use temporary package.json files. This is groundwork for: - Pluggable npm clients (yarn). - An `asini upgrade` command.
rygine
reviewed
Oct 25, 2016
| // We have a few housekeeping tasks to take care of whether we succeed or fail. | ||
| const done = (err) => { | ||
| cleanup(); | ||
| unregister(); |
Contributor
There was a problem hiding this comment.
is cleanup() not guaranteed to run in unregister()?
Contributor
Author
There was a problem hiding this comment.
unregister() unschedules the onExit() cleanup, which we only need if we wind up exiting before this done() function is called.
rygine
reviewed
Oct 25, 2016
| // Handles scoped packages. | ||
| // Returns undefined for version if none specified. | ||
| static splitVersion(dep) { | ||
| return dep.match(/^(@?[^@]+)(?:@(.+))?/).slice(1, 3); |
Contributor
Author
There was a problem hiding this comment.
Yeah, I originally used a simple .split("@"), but then I remembered scoped packages. 😖
Contributor
|
so no more edit: sorry, this was slightly rhetorical. i see that this is the case. just |
Contributor
Author
Right! This is important for |
gigabo
added a commit
to gigabo/lerna
that referenced
this pull request
Feb 3, 2017
Use temporary package.json files. This is groundwork for: - Pluggable npm clients (yarn). - A `lerna upgrade` command. This is a port of asini/asini#45.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use temporary package.json files.
This is groundwork for:
asini upgradecommand.