Add support for configurable package locations#1
Merged
gigabo merged 1 commit intoasini:masterfrom Sep 19, 2016
Merged
Conversation
gigabo
force-pushed
the
configurable-package-locations
branch
2 times, most recently
from
b781b98 to
82c7778
Compare
This adds a `packages` configuration option to `asini.json`:
```json
{
"asini": "x.x.x",
"version": "0.2.3",
"packages": [
{"glob": "packages/{core,plugins}/*/package.json"},
{"glob": "build-tools/package.json"},
{"glob": "integration-tests/**/package.json"}
]
}
```
The default is `[{"glob": "packages/*/package.json"}]`, which is equivalent to
the historical layout of an Asini repo.
gigabo
force-pushed
the
configurable-package-locations
branch
from
82c7778 to
fd83c25
Compare
Contributor
Author
|
I'm sure this has issues that we'll uncover as we start using it. It works for the basic repo structure, though, so I think it's good enough to start with. I have changes built on top of this that are blocked right now. So, going to merge and move on. Please still have a look if you get a chance. And try it out! Find some bugs! 🐛 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
packagesconfiguration option toasini.json:{ "asini": "x.x.x", "version": "0.2.3", "packages": [ {"glob": "packages/{core,plugins}/*/package.json"}, {"glob": "build-tools/package.json"}, {"glob": "integration-tests/**/package.json"} ] }The default is
[{"glob": "packages/*/package.json"}], which is equivalent tothe historical layout of an Asini repo.