Windows support: blockers to compile (#2-#5)#14
Merged
MasonStation merged 5 commits intomainfrom Apr 21, 2026
Merged
Conversation
Enables Windows Credential Manager backend. Without this the keyring crate compiles on Windows with no backend available; all secret ops fall through to the encrypted file vault. macOS and Linux behavior unchanged. Closes #2 Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
'which' is not present on Windows. Using the which crate handles PATH resolution cross-platform and respects Windows' ';' separator and PATHEXT (.exe/.cmd/.bat). Closes #3 Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Windows has no 'kill' command. Gate existing Unix code with cfg(unix) and add a cfg(windows) branch using taskkill /PID /F. Unix behavior unchanged. Closes #4 Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
libc is Unix-only. std::io::IsTerminal (stable since 1.70) works on all platforms with no external dependency. This also fixes a latent bug: the previous check was gated with cfg(unix), so on Windows the non-interactive-context guard was silently skipped — AI agents could run 'phantom reveal' without --yes. The new check runs on all platforms. Drops the now-unused libc dep from phantom-cli. Closes #5 Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Catches Windows regressions in CI. Part of #11 — the issue closes when all remaining Windows support items land. Contributes to #1 Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This was referenced Apr 21, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First slice of #1 (Windows support).
Summary
windows-nativefeature to keyring (vault: addwindows-nativefeature to keyring dependency #2)whichshell-out with thewhichcrate (cli: replacewhichshell-out with cross-platform lookup #3)taskkillpath forphantom stop(cli: add Windowstaskkillpath forphantom stop#4)libc::isattyforstd::io::IsTerminal— also fixes a latent bug where the non-interactive guard onphantom revealwas silently skipped on Windows (cli: replacelibc::isatty()with cross-platform TTY detection #5)libcdep fromphantom-cliwindows-latestto CI matrix (partial ci: addwindows-latestto test matrix #11)All changes are additive; Unix code paths are gated
cfg(unix)and unchanged in behavior.Test plan
ubuntu-latestmacos-latestwindows-latest— the whole pointcargo testpass locally (blocked by Smart App Control on the dev machine; relying on CI)Closes #2, #3, #4, #5