Skip to content

fix: append ANSI reset to preview pane lines to prevent style bleed#420

Merged
asheshgoplani merged 1 commit intoasheshgoplani:mainfrom
gmkanat:fix/ansi-bleed-preview-pane
Mar 26, 2026
Merged

fix: append ANSI reset to preview pane lines to prevent style bleed#420
asheshgoplani merged 1 commit intoasheshgoplani:mainfrom
gmkanat:fix/ansi-bleed-preview-pane

Conversation

@gmkanat
Copy link
Copy Markdown
Contributor

@gmkanat gmkanat commented Mar 22, 2026

Summary

  • Lines with ANSI escape codes (background colors, reverse video) in the preview pane could bleed their styling into lipgloss padding and adjacent dashboard panels
  • Appends an ANSI reset sequence (\x1b[0m) to each line in renderPreviewPane to ensure terminal styling is always contained

Test plan

  • Open agent-deck dashboard with sessions that produce colored/styled output
  • Verify preview pane no longer bleeds background colors or reverse video into surrounding panels
  • Confirm normal (unstyled) output still renders correctly

Lines with ANSI escape codes (background colors, reverse video) in the
preview pane could bleed their styling into lipgloss padding and
adjacent dashboard panels. Appending a reset sequence (\x1b[0m) to
each line ensures terminal styling is contained.
@gmkanat gmkanat force-pushed the fix/ansi-bleed-preview-pane branch from af9988f to 73046d3 Compare March 22, 2026 14:03
@gmkanat
Copy link
Copy Markdown
Contributor Author

gmkanat commented Mar 22, 2026

Before:
image

After:
image

Before:
image

After:
image

Steven17D pushed a commit to Steven17D/agent-deck that referenced this pull request Mar 25, 2026
@asheshgoplani asheshgoplani merged commit 9fac341 into asheshgoplani:main Mar 26, 2026
asheshgoplani added a commit that referenced this pull request Mar 26, 2026
Reverts #422 (Ctrl+Q bind), #420 (ANSI reset), #418 (extended-keys CSI u),
#394 (keyboard mode after detach). These changes broke session creation and
restart on macOS due to terminal capability detection differences.

Also adds schema migration upgrade tests for statedb.

Committed by Ashesh Goplani
Steven17D pushed a commit to Steven17D/agent-deck that referenced this pull request Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants