remove flicker when navigating sidebar#376
Merged
asheshgoplani merged 1 commit intoasheshgoplani:mainfrom Mar 26, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the left sidebar’s group-row rendering to avoid a visual “shift” by keeping the root group hotkey indicator visible even when the group is selected.
Changes:
- Always render the root group hotkey indicator (1–9) regardless of selection state.
- Update the related inline comment to match the new behavior.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+9139
to
9141
| if item.Level == 0 { | ||
| if item.RootGroupNum >= 1 && item.RootGroupNum <= 9 { | ||
| hotkeyStr = GroupHotkeyStyle.Render(fmt.Sprintf("%d·", item.RootGroupNum)) |
Comment on lines
+9136
to
9142
| // Hotkey indicator (subtle, only for root groups) | ||
| // Uses pre-computed RootGroupNum from rebuildFlatItems() - O(1) lookup instead of O(n) loop | ||
| hotkeyStr := "" | ||
| if item.Level == 0 && !selected { | ||
| if item.Level == 0 { | ||
| if item.RootGroupNum >= 1 && item.RootGroupNum <= 9 { | ||
| hotkeyStr = GroupHotkeyStyle.Render(fmt.Sprintf("%d·", item.RootGroupNum)) | ||
| } |
naps62
changed the title
… shift Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
naps62
force-pushed
the
feature/dont-shift
branch
from
f0e6275 to
01db686
Compare
Steven17D
pushed a commit
to Steven17D/agent-deck
that referenced
this pull request
Mar 25, 2026
Steven17D
pushed a commit
to Steven17D/agent-deck
that referenced
this pull request
Mar 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove the 1-char shift that happens when navigating the sidebar, due to the number disappearing when hovering a session
this is a UI annoyance only