fix: detect Ctrl+Q in enhanced keyboard protocol encodings#357
Closed
PatrickStraeter wants to merge 1 commit intoasheshgoplani:mainfrom
Closed
fix: detect Ctrl+Q in enhanced keyboard protocol encodings#357PatrickStraeter wants to merge 1 commit intoasheshgoplani:mainfrom
PatrickStraeter wants to merge 1 commit intoasheshgoplani:mainfrom
Conversation
Modern terminals with kitty keyboard protocol or xterm modifyOtherKeys encode Ctrl+Q as escape sequences (ESC[113;5u or ESC[27;5;113~) instead of raw byte 0x11. This broke detach in local sessions after the inner process enabled enhanced reporting, and in SSH remote sessions. Extract IndexCtrlQ into a shared function in internal/tmux that handles all three encodings, and use it in both the local PTY attach and SSH attach paths. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
asheshgoplani
added a commit
that referenced
this pull request
Mar 18, 2026
Owner
|
Merged to main with added unit tests for IndexCtrlQ (9 test cases covering raw byte, xterm modifyOtherKeys, and kitty keyboard protocol encodings). Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modern terminals with kitty keyboard protocol or xterm modifyOtherKeys encode Ctrl+Q as escape sequences (ESC[113;5u or ESC[27;5;113~) instead of raw byte 0x11. This broke detach in local sessions after the inner process enabled enhanced reporting, and in SSH remote sessions.
Extract IndexCtrlQ into a shared function in internal/tmux that handles all three encodings, and use it in both the local PTY attach and SSH attach paths.