Fix #344: prevent shortcut keys from intercepting text input in new session dialog#346
Merged
asheshgoplani merged 1 commit intomainfrom Mar 17, 2026
Merged
Conversation
… in new session dialog (#344) When a text input field is focused (name, path, branch, or custom command), single-letter shortcuts (s/w/m/y) now correctly type into the input instead of toggling checkboxes. Added isTextInputFocused() helper to detect active text input state and guard all single-letter shortcut handlers. Committed by Ashesh Goplani
This was referenced Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isTextInputFocused()helper that detects when a text input field (name, path, branch, or custom command) is actively receiving keystrokess,w,m,y) so they only fire when no text input is focusedTestNewDialog_ShortcutsBlockedDuringTextInputtest covering the fixFixes #344