Skip to content

feat(ui): add Pi support, configurable hotkeys, and preview notes#285

Merged
asheshgoplani merged 2 commits intoasheshgoplani:mainfrom
Microck:feature/configurable-hotkeys-notes-close-session
Mar 6, 2026
Merged

feat(ui): add Pi support, configurable hotkeys, and preview notes#285
asheshgoplani merged 2 commits intoasheshgoplani:mainfrom
Microck:feature/configurable-hotkeys-notes-close-session

Conversation

@Microck
Copy link
Copy Markdown
Contributor

@Microck Microck commented Mar 4, 2026

Summary

  • add built-in pi tool support across session creation, detection, styling, defaults, and config parsing
  • add a non-destructive close-session flow (D by default) separate from delete (d)
  • add config-driven hotkeys with override/unbind support and dynamic key labels in help bars, tooltips, dialogs, and preview hints
  • add optional instances.follow_cwd_on_attach to update ProjectPath/tmux workdir after attach returns
  • add per-session notes editing in preview with persistent storage and configurable preview.notes_output_split

Testing

  • go test ./internal/ui
  • go test ./internal/session
  • CGO_ENABLED=1 make test

Notes

  • stabilize session tests to avoid environment-dependent failures: deterministic mtime ordering in TestFindActiveSessionIDExcluding and graceful skips for OpenCode integration/E2E cases when local CLI state is unavailable (no sessions or unauthenticated JSON output)

Microck added 2 commits March 4, 2026 01:15
Add config-driven hotkey remapping (including unbind support) and wire dynamic key labels across help, hints, dialogs, and preview actions.

Introduce non-destructive close-session action separate from delete, add preview notes editing with persistence, and support optional follow-CWD-on-attach path updates with targeted tests.
Make active-session selection deterministic by setting explicit file mtimes in TestFindActiveSessionIDExcluding.

Skip OpenCode integration and E2E assertions when local CLI state is unavailable (no sessions or unauthenticated JSON output), so test runs stay deterministic across developer environments.
@Abeansits
Copy link
Copy Markdown
Contributor

nice idea @Microck! As a suggestion though, I would split this PR into multiples instead of conflating ~5 features in one. Your chances of getting a code review is also higher the smaller the PR.

Features I detected:

  1. Pi tool support
  2. Close-session flow (non-destructive D)
  3. Configurable hotkeys with override/unbind
  4. follow_cwd_on_attach option
  5. Per-session notes editing in preview

@asheshgoplani asheshgoplani merged commit 00c0c4e into asheshgoplani:main Mar 6, 2026
1 check passed
@asheshgoplani
Copy link
Copy Markdown
Owner

Merged and included in v0.21.0. Thanks for the contribution. The Pi support, configurable hotkeys, and preview notes work all landed cleanly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants