Fix tac on OSX if coreutils are linked in path#216
Conversation
|
Thanks for the PR! If |
|
What about this for the Can you test this out on your machine? And, if what are you thoughts on changing the conditional to this? |
|
You're right, it's better to make it fallback for everyone. Made the changes, anything else? On a side note: caching for this plugin is heavily needed. |
|
Thanks for updating this @arikai ! I was on vacation, sorry for the late merge! |
|
Don't worry, just was trying to understand the circumstances :) |
* Fix tac on osx if coreutils are linked in path * Change fallback condition for `tac`. Provide space-safe implementation
One of recent commits (6667b31) dealed with
tacnot being present onPATHon OSX systems.The problem is that
coreutilsis widely installed (viabrew) on OSX systems by developers and it in fact includes missingtacutility! But itstailis missing-rflag:This PR adds a check before implementing tac over
tailto see if tac is present.