Repository navigation
Consider upgrading to jsonschema 3.0 #530
Description
Currently there's only an alpha release, and it causes some errors that are detected by our unit tests. However, once things become more stable we should consider whether we should upgrade, and if so, what changes will need to be made.
Version 3.0 introduces support for Draft-06. This could potentially allow us to update the ASDF Standard to support Draft-06 as well. However, if we are really serious about providing/supporting multiple implementations of ASDF, we need to look at the lowest common denominator across JSON Schema implementations, which might still be Draft-04.
Activity
perrygreenfield commentedon Aug 9, 2018
Is there any urgency to do this? (e.g., very useful new functionality or backward incompatible changes?) Otherwise, we would tend to take a slow approach to such things.
drdavella commentedon Aug 9, 2018
No, there's no urgency. I just wanted to record the issue here as a reminder for future reference.
That being said, if it's not difficult to upgrade to 3.0 (once it's stable), then we should, since that's presumably where all bug fixes and improvements will wind up.
perrygreenfield commentedon Aug 9, 2018
Agreed. We should evaluate it once is it a stable release.
nden commentedon Aug 20, 2018
I came upon this stackoverflow discussion about using
implicationsandif ... elsein jsonschema. May be I missed it but I didn't see which versions of the schema support this. However, this looks very useful to have.drdavella commentedon Aug 20, 2018
Yes, it does seem very useful. I believe it is supported as of Draft-07. The
jsonschemaPython module doesn't yet support that draft (and only supports Draft-06 in alpha releases), but it looks like Draft-07 may be supported relatively soon.Even after that point, moving to Draft-07 may disadvantage other potential implementations of ASDF since JSON Schema support in other languages may not be as advanced. We'll need to have a discussion about how much that really matters, though.
pllim commentedon Nov 15, 2018
Somehow 3.0 get picked up by one of my conda install that happened before I installed
asdf. This caused conflict and to solve that:conda uninstall jsonschemaThen, I tried
pip install jsonschemaand that picked up 2.x but that did not work either.asdfgave a cryptic message about cannot understand something when I load a file. What finally worked:pip uninstall jsonschemaasdffrommasterand letasdfinstalljsonschemain the processI would say this kind of installation hurdle is not very user-friendly right now. I spent 30 minutes trying to make this work. FYI.
drdavella commentedon Nov 15, 2018
Can you provide the error message? It shouldn't have been necessary to do the
pip install jsonschemastep since it's explicitly given as a dependency ofasdf, but it would be useful to see the error.pllim commentedon Nov 15, 2018
"Cannot understand something something 1.3.0"
I tried to reproduce it in a clean env but I cannot now. I swear it was happening last night. @ejeschke can be my witness!
The fact that
asdfinstallsjsonschemaif not there is nice, but it wasn't playing nice withjsonschemathat is already installed (for one reason or another).drdavella commentedon Nov 15, 2018
I can't reproduce it either. I realize it's annoying to have a strict dependency on
jsonschema, but that's just the situation we have for the near term. Maybe I can try to address this for 2.3.0, but it also depends on which versions of Pythonjsonschema-3.0supports. Also the fact that the latest released version ofjsonschemaon pypi is 2.6.0 means that I don't feel a strong need to do this immediately.drdavella commentedon Nov 15, 2018
Given the error message snippet you reported, it sounds like you were probably trying to read a file that was recently produced by the JWST pipeline. Unfortunately, since they run against a dev version of ASDF, it means that you won't be able to use a stable version to read their files. So installing from
masterwas the right thing to do.For the record, this issue is unrelated to the version of
jsonschema.Cadair commentedon Mar 7, 2019
It's worth noting that the
jsonschema 3.0.1package is now up on PyPI and the like.drdavella commentedon Mar 7, 2019
There's actually a 3.0 release of
jsonschemanow so this has become more urgent/relevant.pllim commentedon Jun 20, 2019
jsonschema<3now gives this warning:It has been fixed in
jsonschema>=3. Indirectly, this means that ifasdfdoes not supportjsonschema>=3,asdfwill not work in Python 3.8.pllim commentedon Jul 28, 2019
Might still be a problem, see #684 (comment). This is giving me a headache, because Jupyter is asking for
jsonschema>=3.jdavies-st commentedon Jul 30, 2019
This is an order-of-installation issue, not a problem in
asdf.Fixed by #684.