Repository navigation
fix: flush ci --json output before exiting - #153
Merged
asamassekou10 merged 1 commit intoAug 15, 2026
Merged
asamassekou10 merged 1 commit into
asamassekou10 merged 1 commit into
Conversation
asamassekou10
force-pushed
the
false-positive-benchmark-fails-fix
branch
from
August 15, 2026 08:46
cf8ad10 to
bf7da0b
Compare
Owner
|
Thanks for the contribution, Alvaro. I rebased this onto the current main, kept your large-output regression test, and merged it with the bounded stdout handling already in place |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ci command wrote its --json report with console.log and then called process.exit() right after, but on a piped stdout large writes flush asynchronously, so exit could fire before the write finished and truncate the JSON - this is what broke the false-positive benchmark against the Hermes corpus. I changed it to wait for the pending write to actually complete before exiting, and added a regression test that scans a project with thousands of findings and confirms the JSON output parses in full.
Fixes #147.
I pushed this to my fork first and the project's own CI workflows pass on the commit.