Fix debug_size_heap::extra_size to always be 8 on MinGW 32bit builds #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
=======================================
Coverage 94.53% 94.53%
=======================================
Files 87 87
Lines 7009 7009
=======================================
Hits 6626 6626
Misses 383 383
Continue to review full report at Codecov.
|
Owner
|
Thanks a lot! 👍 |
Fuzzbawls
added a commit
to PIVX-Project/PIVX
that referenced
this pull request
Apr 4, 2023
…ubtree d454272 [Lint] Ignore src/immer in lint-whitespace.sh (Fuzzbawls) 751fd3f [GA] Lint src/immer with git-subtree-check.sh (Fuzzbawls) 35c0d52 Squashed 'src/immer/' content from commit abb2b02e34 (Fuzzbawls) 98eab06 [Cleanup] Remove immer sources in prep for subtreeing (Fuzzbawls) Pull request description: Reintroduce the header-only immer library as a git subtree and bump the version to the latest v0.7.0 (commit 9cb6a5a845df766a4cb3526d8a4584bf99bac8d5). Since we only really want the header sources, this subtree is a bit different than our other subtrees. I've used `git subtree split` to extract out only the relevant `immer` path from the source repo, and then added that split out path as a git subtree. this method is documented at https://jrsmith3.github.io/merging-a-subdirectory-from-another-repo-via-git-subtree.html This ultimately allows us to lint that the `src/immer` path remains unchanged by manual commits, like any other 3rd party subtree library that we use (chiabls, crc32c, leveldb, secp256k1, univalue). I bumped the version of immer used so as to include a fix proposed by @codablock (arximboldi/immer#80), which was later merged upstream. this particular PR does not affect PIVX whatsoever, as we no longer ship 32-bit windows binaries, but v0.7.0 was officially released on Nov 8, 2021. Note to reviewers: best to view this with whitespace-only changes ignored. ACKs for top commit: Liquid369: tACK d454272 panleone: tACK d454272 Tree-SHA512: 6301a4d5a73a524b02794a1e7a1830406a39bd74338d7cb652346657367ab06c024f93a03fbca34c0015dbc0498b78552a224319f650d2f4f158671f2ada95a3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #78
I chose to hardcode it to 8 because the alternative of
sizeof(void*) * 2is not really connected to howstd::max_align_tis defined.