Repository navigation
deps: upgrade codex to 0.169.0 - #2174
github-actions[bot] wants to merge 1 commit into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the
|
| "@linear/sdk": "^84.0.0", | ||
| "@modelcontextprotocol/sdk": "^1.29.0", | ||
| "@openai/codex": "0.167.0", | ||
| "@openai/codex": "0.167.1", |
There was a problem hiding this comment.
Bumping @openai/codex to 0.167.1 leaves PINNED_CODEX_APP_SERVER_VERSION at 0.167.0. The test pins the app-server version ADE ships reads this dependency and compares it directly with that constant, so the desktop test suite will fail. Update the declared pin alongside the dependency.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/ade-cli/package.json
Line: 39
Comment:
**Codex pin test fails**
Bumping `@openai/codex` to `0.167.1` leaves `PINNED_CODEX_APP_SERVER_VERSION` at `0.167.0`. The test `pins the app-server version ADE ships` reads this dependency and compares it directly with that constant, so the desktop test suite will fail. Update the declared pin alongside the dependency.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.87e083c to
ace6beb
Compare
ace6beb to
99ba092
Compare
There was a problem hiding this comment.
🔍 Devin Review: 2 flags
Not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)
codex has a new version: 0.167.0 → 0.169.0.
This branch already has the version bump. Make a lane from this PR to test and finish the upgrade:
A newer release updates this same PR. When main has the newest version, this PR closes by itself.
The PR should not merge until the previously reported Codex pin test failure is fixed.
Fix with agent prompt
Summary
Upgrades
@openai/codexfrom0.167.0to0.169.0, beyond the version named in the PR title.Reviews (3) · Last reviewed commit: "deps: upgrade codex to 0.169.0" · Reviewed by Greptile