Refactor PartitionKeys and add StoragePartition#99
Merged
JacobHayes merged 9 commits intogoldenfrom Sep 29, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## golden #99 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 24 26 +2
Lines 1175 1419 +244
Branches 156 197 +41
==========================================
+ Hits 1175 1419 +244
Continue to review full report at Codecov.
|
… arbitrary fields
JacobHayes
force-pushed
the
partitioning
branch
from
c1517c3 to
a16fc3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of filling out the partitioning logic, I:
Partitioner(to be replaced with a field reference/operation in the future)PartitionKeyto be a simple value with a set of optionalkey_components that can subdivide the keyStoragePartitionconcept representing a single partition containing namedPartitionKeysStorageto discover/buildStoragePartitiongiven the set of partition key types and a format-string referencingPartitionKeyvalues (or their components).This still needs more tweaking (in future PRs/work), but largely things that will build on top of this (introducing
ArtifactPartition, working outProducer.map, etc).