Replace Type.metadata with TypeSystem hints#90
Merged
JacobHayes merged 1 commit intogoldenfrom Sep 8, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## golden #90 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 1119 1087 -32
Branches 144 139 -5
=========================================
- Hits 1119 1087 -32
Continue to review full report at Codecov.
|
JacobHayes
force-pushed
the
metadata-to-hints
branch
from
e31537d to
f8b2a92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than storing arbitrary
Type.metadatafor use as "hints" during TypeSystem conversions, this formalizes ahintsargument to theto_artigraphandto_systemTypeSystem/TypeAdaptermethods.In the future, we may add some (optional) "supported hints" Enum validation (eg:
sgqlc_type_systemaccepts "sgqlc.abstract" and "sgqlc.interfaces" hints).