Skip to content

Comments

Add Type.nullable and Enum(Type)#82

Merged
JacobHayes merged 5 commits intogoldenfrom
python-type-system-hints
Aug 23, 2021
Merged

Add Type.nullable and Enum(Type)#82
JacobHayes merged 5 commits intogoldenfrom
python-type-system-hints

Conversation

@JacobHayes
Copy link
Member

Expands the Type system to support nullable types and typed Enums.

This should help with #75 - we can now convert the Timestamp.precision definition to an Enum.

@JacobHayes JacobHayes self-assigned this Aug 21, 2021
@JacobHayes JacobHayes requested a review from joycex99 August 21, 2021 03:42
@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #82 (fa321e6) into golden (e2aaf19) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            golden       #82   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          833       916   +83     
  Branches        97       116   +19     
=========================================
+ Hits           833       916   +83     
Impacted Files Coverage Δ
src/arti/internal/type_hints.py 100.00% <100.00%> (ø)
src/arti/types/__init__.py 100.00% <100.00%> (ø)
src/arti/types/python.py 100.00% <100.00%> (ø)
src/arti/views/python.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55e7a37...fa321e6. Read the comment docs.

@JacobHayes JacobHayes force-pushed the python-type-system-hints branch from 2faed10 to 5238fb5 Compare August 21, 2021 05:39
Base automatically changed from type-frozen-metadata to golden August 23, 2021 17:39
@JacobHayes JacobHayes force-pushed the python-type-system-hints branch from 5238fb5 to fa321e6 Compare August 23, 2021 18:14
@JacobHayes JacobHayes merged commit 79a399b into golden Aug 23, 2021
@JacobHayes JacobHayes deleted the python-type-system-hints branch August 23, 2021 18:27
@JacobHayes
Copy link
Member Author

Still happy to take any reviews on this or #81 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant