Add ObjectBox and frozen Type.metadata#81
Merged
JacobHayes merged 2 commits intogoldenfrom Aug 23, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## golden #81 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 814 833 +19
Branches 93 97 +4
=========================================
+ Hits 814 833 +19
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Type.metadataas a frozenBoxto support arbitrary type metadata (eg: as a lightweight alternative toStruct.{abstract,interfaces}in #75).I first played around with the
frozendictpackage, but had a few (avoidable) issues before remembering that theBoxpackage we already use (forGraph.artifacts) supportsfrozen_box=Trueand automatically freezes dicts+lists recursively.