Conversation
mikss
commented
Jul 29, 2021
|
|
||
| @classmethod | ||
| def to_artigraph(cls, type_: Any) -> Type: | ||
| return cls.artigraph(precision="microsecond") |
Contributor
Author
There was a problem hiding this comment.
This is because datetime precision is microsecond.
JacobHayes
reviewed
Aug 2, 2021
Member
JacobHayes
left a comment
JacobHayes
left a comment
There was a problem hiding this comment.
Thanks, looking pretty good! The Struct conversion seems clean, barring more esoteric things like typing.Optional (which we need to figure out/tweak in a few places to handle issubclass).
Codecov Report
@@ Coverage Diff @@
## golden #74 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 685 727 +42
Branches 79 86 +7
=========================================
+ Hits 685 727 +42
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I expand out the types within the Python TypeSystem. I do think the Struct implementation is a little shaky, but let me know what you think. I tried to be generic with
_gen_adapterwhere possible, but let me know if I am missing something obvious.