Conversation
c680622 to
a5c4470
Compare
Codecov Report
@@ Coverage Diff @@
## golden #73 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 671 687 +16
Branches 70 77 +7
=========================================
+ Hits 671 687 +16
Continue to review full report at Codecov.
|
e00b2b9 to
1415ad7
Compare
mikss
reviewed
Jul 28, 2021
87a2a40 to
8f824c5
Compare
282148a to
3157720
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this lays most of the foundation for
pydanticProducers. In order to build the appropriate model, aProducermust now set the fields in the top level matching the.buildsignature.I still need to:
.build/.maparguments are a subset of the model ones (cls.__fields__) and match on typeValidate no Optional/default None fields or add support for themWe should support optional, but the Fingerprint logic mentioned below doesn't exist yet (so will keep in mind)In future PRs, I'll take a stab at:
builddecorator -> Producer subclass (auto setup fields)