Conversation
JacobHayes
force-pushed
the
pydantic-prep
branch
from
8105903 to
fd4a630
Compare
Codecov Report
@@ Coverage Diff @@
## golden #72 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 699 709 +10
Branches 81 80 -1
=========================================
+ Hits 699 709 +10
Continue to review full report at Codecov.
|
JacobHayes
force-pushed
the
pydantic-artifacts
branch
from
c680622 to
a5c4470
Compare
mikss
approved these changes
Jul 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Artifact classes to be pydantic models.
Artifacts were the only objects we mutated (when setting
Artifact.producerwithinProducer.out), but rather than mutate we now copy the Artifact and return an updated version. This will require the output ofProducer.outto be assigned to theGraph, rather than something likeg.artifacts.x = MyArtifact(...); MyProducer().out(g.artifacts.x)- but that seems quite fine.