Rename non-standard dunder attributes to sunder#70
Merged
JacobHayes merged 1 commit intogoldenfrom Jul 27, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## golden #70 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 685 685
Branches 79 79
=========================================
Hits 685 685
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a handful of custom dunder (
__<name>__) properties and methods, but those should be reserved for python magics. Instead, taking a hint fromenum, I moved all of the custom dunders to sunders (_<name>_).