Support registration priority and use for Views#69
Merged
JacobHayes merged 2 commits intogoldenfrom Jul 26, 2021
Merged
Conversation
JacobHayes
commented
Jul 26, 2021
| super().__init_subclass__(**kwargs) | ||
| if not cls.__abstract__: | ||
| register(cls._registry_, cls.python_type, cls) | ||
| register(cls._registry_, cls.python_type, cls, lambda x: x.priority) |
Member
Author
There was a problem hiding this comment.
I was gonna use attrgetter("priority") here, but mypy was a bit less strict - it could detect a misspelling like prioritiyz with a lambda, but not attrgetter. 🤷
mikss
approved these changes
Jul 26, 2021
Contributor
mikss
left a comment
mikss
left a comment
There was a problem hiding this comment.
Thanks, this is great.
I don't know where to put this in the code, so I'll record the thought here: .priority is dict-y for Views (b/c it's just type-to-view key-value lookup), but for-loop-y for TypeAdapters. This is probably fine, but just a quirk that .priority underlying usage is different for the two, despite similar naming of the two concepts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for priority-based registration (and erroring) to support the new
Viewregistration in #66.I don't add
get_prioritytoTypeSystemregistration since the key there (class name / "key") isn't very meaningful. That might make more sense if we splitTypeSystem._adapter_by_keyto separateinternalandsystemregistries.