Conversation
Codecov Report
@@ Coverage Diff @@
## golden #66 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 22 22
Lines 668 679 +11
Branches 74 75 +1
=========================================
+ Hits 668 679 +11
Continue to review full report at Codecov.
|
JacobHayes
reviewed
Jul 24, 2021
Member
JacobHayes
left a comment
JacobHayes
left a comment
There was a problem hiding this comment.
Good improvement, thanks! A few interface Qs, but glad to see the read/write will work so simply.
mikss
commented
Jul 26, 2021
|
|
||
|
|
||
| RegisterK = TypeVar("RegisterK", bound=str) | ||
| RegisterK = TypeVar("RegisterK") |
Contributor
Author
There was a problem hiding this comment.
This is so we can register .python_type as a key.
Co-authored-by: Jacob Hayes <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some discussion about Views, we came to some level of agreement that Views should encode “structural” metadata about the object’s form (e.g.,
int), rather than “environmental” metadata about where the object is being worked on (e.g., via Python interpreter). Note that BigQuery is a confusing case, because a BigQuery table is both a form in which data is manipulated, and BigQuery is also the managed database service through which tables are manipulated.Given the above, this PR refactors the example view to be an
Int, rather thanPython(although this remains as a helpful superclass in the renamed form_PythonObject, for ease of general read/write).