Add TypeAdapter.matches_* methods and expand tests#64
Merged
mikss merged 1 commit intotrivial_artifactfrom Jul 21, 2021
Merged
Conversation
mikss
approved these changes
Jul 21, 2021
Contributor
mikss
left a comment
mikss
left a comment
There was a problem hiding this comment.
Thanks, this makes sense to me.
I like the renaming from internal/external/core to artigraph/system.
JacobHayes
added a commit
that referenced
this pull request
Jul 21, 2021
JacobHayes
added a commit
that referenced
this pull request
Jul 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
TypeAdaptermatching will need to be a bit more robust/dynamic to support different systems, eg:google.cloud.bigquery: types are specified within thefield_typeinstance attribute of aSchemaFieldclasspyarror: types each have a specific class, which users instantiate to configurepython: types are singletons, each an instance oftypeTo support these different approaches, I extended
TypeAdapterto add extramatches_{artigraph,system}methods that can be overridden a bit more easily. ForTypeSystem(key="python")specifically, I added a_SingletonTypeAdapterand a class generator to ease expanding the simple types (without required arguments, eg: Int32). I'm not sure how well those helpers will generalize, so put them intotypes/python.pyspecifically for now.I also tried to fix some of the dissonance w/ the conversion method names between
TypeAdapterandTypeSystemFollow up from: #58 (review)