Skip to content

Comments

CI Tweaks#6

Merged
JacobHayes merged 4 commits intogoldenfrom
ci-tweaks
Feb 21, 2021
Merged

CI Tweaks#6
JacobHayes merged 4 commits intogoldenfrom
ci-tweaks

Conversation

@JacobHayes
Copy link
Member

@JacobHayes JacobHayes commented Feb 17, 2021 •
edited
Loading

  • Adds a starting pylint config - it's not enforced in tests, just reduces noise a bit for folks who have it setup
  • Disables GitHub Action "fail fast" so we can get coverage and more details sooner
  • Sets the coverage min to 90% for the pre-commit hook to ease iterative development. CI/PRs still enforce 100%
  • Remove nominal support for python 3.8 - PEP 585 stdlib container generics are quite convenient. If 3.8 becomes important, we can add compat layers later

@JacobHayes JacobHayes self-assigned this Feb 17, 2021
@codecov
Copy link

codecov bot commented Feb 17, 2021 •
edited
Loading

Codecov Report

Merging #6 (34b77da) into golden (d69661b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            golden        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            2         2           
=========================================
  Hits             2         2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d69661b...34b77da. Read the comment docs.

@JacobHayes JacobHayes added the github_actions Pull requests that update Github_actions code label Feb 17, 2021
@JacobHayes JacobHayes merged commit 6323703 into golden Feb 21, 2021
@JacobHayes JacobHayes deleted the ci-tweaks branch February 21, 2021 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@marcopalmeri marcopalmeri marcopalmeri approved these changes

@mprafson mprafson mprafson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@JacobHayes JacobHayes

Labels

github_actions Pull requests that update Github_actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JacobHayes @marcopalmeri @mprafson