Conversation
Codecov Report
@@ Coverage Diff @@
## golden #35 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 13 14 +1
Lines 378 496 +118
Branches 56 65 +9
==========================================
+ Hits 378 496 +118
Continue to review full report at Codecov.
|
73be2e3 to
7f45735
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a base Fingerprint class that will be used as a fingerprint for Artifacts, Producer Versions, etc. Fingerprints are represented as an int64. When fingerprinting string content, we use the farmhash Fingerprint64 algorithm (via
pyfarmhash), but convert the uint64 to int64 using two's compliment.I also (went a little overboard and) added int64/uint64 types to enforce clear casting behavior + mypy static typing
Relates to #30 - I'll be adding the concrete use in Storage and Views in a follow up PR.
--
int64:
BigNumber/json-bignumberor treat as strings).Farmhash Fingerprint64:
HASH/HASH_AGG, but perhaps we can request farmhash or add via a JS UDF)For systems that don't support farmhash, we can use an alternate mechanism (eg: Snowflake's
HASH_AGG) with the caveat that content fingerprints won't be portable when/if changing storage/view.