Skip to content

Comments

Remove Format.type and Storage.{type,format} fields#344

Merged
JacobHayes merged 2 commits intogoldenfrom
remove-redundent-refs
Mar 20, 2023
Merged

Remove Format.type and Storage.{type,format} fields#344
JacobHayes merged 2 commits intogoldenfrom
remove-redundent-refs

Conversation

@JacobHayes
Copy link
Member

Description

The Format.type and Storage.{type,format} references lead to a lot of pointed fingers, which makes (de)serialization of these types much trickier. We don't really need these references during normal operations, only during "initialization" (used loosely to mean the time between initial object creation through sealing the Graph).

This replaces those fields and validators with _visit_{name} methods that perform any checking and, if needed, return a modified copy with updated attributes (eg: resolving Storage path templates).

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@JacobHayes JacobHayes requested a review from JamesOswald March 20, 2023 04:01
@JacobHayes JacobHayes force-pushed the remove-redundent-refs branch from dc94d28 to 59c941e Compare March 20, 2023 05:50
@JacobHayes JacobHayes merged commit dd53807 into golden Mar 20, 2023
@JacobHayes JacobHayes deleted the remove-redundent-refs branch March 20, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants