Remove Format.type and Storage.{type,format} fields#344
Merged
JacobHayes merged 2 commits intogoldenfrom Mar 20, 2023
Merged
Conversation
JamesOswald
approved these changes
Mar 20, 2023
Signed-off-by: Jacob Hayes <[email protected]>
Signed-off-by: Jacob Hayes <[email protected]>
dc94d28 to
59c941e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
Format.typeandStorage.{type,format}references lead to a lot of pointed fingers, which makes (de)serialization of these types much trickier. We don't really need these references during normal operations, only during "initialization" (used loosely to mean the time between initial object creation through sealing the Graph).This replaces those fields and validators with
_visit_{name}methods that perform any checking and, if needed, return a modified copy with updated attributes (eg: resolvingStoragepath templates).Type of change
Please delete options that are not relevant.