Skip to content

Comments

Persist Graph{Snapshot} in Backend#342

Merged
JacobHayes merged 1 commit intogoldenfrom
write-graph
Mar 19, 2023
Merged

Persist Graph{Snapshot} in Backend#342
JacobHayes merged 1 commit intogoldenfrom
write-graph

Conversation

@JacobHayes
Copy link
Member

Description

Adds new methods to Backend to support persisting and retrieving Graphs + GraphSnapshots and retrieving GraphSnapshots from a tag. This also changes a couple of the other Backend methods to accept a GraphSnapshot instance instead of a name, snapshot_id pair.

While working on this, I noticed that hash(graph) could change, even though the models are (intended to be) immutable. This turned out to be due to @cached_propertys, which are now ignored and fixed in 6626530.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Updated tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in upstream modules

@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Merging #342 (9fe5fd4) into golden (fda0821) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            golden      #342   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           43        43           
  Lines         2760      2790   +30     
  Branches       699       706    +7     
=========================================
+ Hits          2760      2790   +30     
Impacted Files Coverage Δ
src/arti/backends/__init__.py 100.00% <100.00%> (ø)
src/arti/backends/memory.py 100.00% <100.00%> (ø)
src/arti/executors/__init__.py 100.00% <100.00%> (ø)
src/arti/graphs/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@JacobHayes JacobHayes merged commit 5fd9ed2 into golden Mar 19, 2023
@JacobHayes JacobHayes deleted the write-graph branch March 19, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant