Use None instead of NoneType when matching annotations#341
Merged
JacobHayes merged 1 commit intogoldenfrom Mar 18, 2023
Merged
Conversation
Signed-off-by: Jacob Hayes <[email protected]>
Codecov Report
@@ Coverage Diff @@
## golden #341 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 43 43
Lines 2738 2747 +9
Branches 692 696 +4
=========================================
+ Hits 2738 2747 +9
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Python normally represents
Nonein type hints with theNonevalue, notNoneType. However, thepython_type_systemwould check forisinstance(annotation, NoneType)when matching, which caused some oddness when trying to validate aNonevalue passed to a model. Instead, we now match onNonedirectly.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Updated tests.
Checklist: