Allow g.read with raw Artifacts even if others are missing#338
Merged
JacobHayes merged 2 commits intogoldenfrom Mar 16, 2023
Merged
Allow g.read with raw Artifacts even if others are missing#338JacobHayes merged 2 commits intogoldenfrom
JacobHayes merged 2 commits intogoldenfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## golden #338 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 43 43
Lines 2722 2724 +2
Branches 686 687 +1
=========================================
+ Hits 2722 2724 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Graph.readwithout any storage partitions passed in (as is common with interactive use) triggers a snapshot. However, if any of the raw Artifacts are missing, snapshotting will fail. This correctly blocks reading generated Artifacts, but we should still be able to read other raw Artifacts that do exist.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Extended a test.
Checklist: