Replace Graph.snapshot_id with new GraphSnapshot#336
Merged
JacobHayes merged 6 commits intogoldenfrom Mar 17, 2023
Merged
Conversation
Member
Author
|
cc @JamesOswald |
Codecov Report
@@ Coverage Diff @@
## golden #336 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 43 43
Lines 2724 2734 +10
Branches 687 690 +3
=========================================
+ Hits 2724 2734 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
6b639da to
6e94488
Compare
Signed-off-by: Jacob Hayes <[email protected]>
Signed-off-by: Jacob Hayes <[email protected]>
3644be6 to
bd9a5e3
Compare
Signed-off-by: Jacob Hayes <[email protected]>
Signed-off-by: Jacob Hayes <[email protected]>
Signed-off-by: Jacob Hayes <[email protected]>
Signed-off-by: Jacob Hayes <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This replaces the optional
Graph.snapshot_idfield with a concreteGraphSnapshotclass. This explicit separation makes it much more easily to reason about (and statically verify with mypy) that a section of code that requires a snapshot (eg: all Executor logic and most io) receives a snapshot, without littering a bunch ofassert graph.snapshot_id is not None. This also makes tagging a bit more clear - you are tagging (and retrieving) a specific snapshot, so having an explicit entity is more clear.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added / updated tests and ran
docs/examples/spend/demo.py.Checklist: