Skip to content

Comments

Add BigQuery TypeSystem#312

Merged
JacobHayes merged 2 commits intogoldenfrom
bigquery
Mar 15, 2023
Merged

Add BigQuery TypeSystem#312
JacobHayes merged 2 commits intogoldenfrom
bigquery

Conversation

@JacobHayes
Copy link
Member

Description

Adds the BigQuery TypeSystem initially written by @bnaul, @rregue, and I. @rregue, it took me a while to get around to adding here, thanks for the patience. 😁 Are there any other changes you all have made and would want to add here?

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added new tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in upstream modules

@JacobHayes
Copy link
Member Author

There are a couple exceptions I need to add test coverage for.

@JacobHayes JacobHayes force-pushed the bigquery branch 2 times, most recently from 2996830 to 1a6209c Compare February 19, 2023 21:53
@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2023

Codecov Report

Merging #312 (1f29c33) into golden (5ef9ece) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 1f29c33 differs from pull request most recent head e8aa0ba. Consider uploading reports for the commit e8aa0ba to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##            golden      #312    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           42        43     +1     
  Lines         2587      2723   +136     
  Branches       652       686    +34     
==========================================
+ Hits          2587      2723   +136     
Impacted Files Coverage Δ
src/arti/types/bigquery.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Co-authored-by: Brett Naul <[email protected]>
Co-authored-by: Robert Regue <[email protected]>
Signed-off-by: Jacob Hayes <[email protected]>
@JacobHayes JacobHayes merged commit 95c9197 into golden Mar 15, 2023
@JacobHayes JacobHayes deleted the bigquery branch March 15, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants