Merged
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## golden #306 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 2599 2599
Branches 654 654
=========================================
Hits 2599 2599 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
JacobHayes
force-pushed
the
artifactbox-nested-assignment-and-pickle
branch
4 times, most recently
from
c711f52 to
01ff940
Compare
Signed-off-by: Jacob Hayes <[email protected]>
Signed-off-by: Jacob Hayes <[email protected]>
JacobHayes
force-pushed
the
artifactbox-nested-assignment-and-pickle
branch
from
01ff940 to
dfa6fd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes pickling a
Graphobject, which was blocked by issues pickling:ArtifactBox- the way we were tracking the nested names was messy and broken when pickling; we can now simplify with some changes upstream tobox(pending v7)MemoryBackend- an internaldefaultdictreferenced an inlinelambda, which can't be pickled (why isn'tcloudpicklethe builtin 😞)Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Added tests
Checklist: