Skip to content

Comments

Move arti.internal.version to arti.__version__#252

Merged
JacobHayes merged 1 commit intogoldenfrom
move-version
Jul 19, 2022
Merged

Move arti.internal.version to arti.__version__#252
JacobHayes merged 1 commit intogoldenfrom
move-version

Conversation

@JacobHayes
Copy link
Member

Description

Once upon a time, I didn't know how to handle extending namespace packages with an __init__.py module (maybe I'm deluding myself that I do now 😁), so moved arti.__version__ to arti.internal.version. That has since been "fixed" with __path__ = __import__("pkgutil").extend_path(__path__, __name__) in the namespace __init__.pys, so we can move the version back for greater visibility.

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Ran tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in upstream modules

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2022

Codecov Report

Merging #252 (67442ac) into golden (b85405a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            golden      #252   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines         2448      2448           
  Branches       513       513           
=========================================
  Hits          2448      2448           
Impacted Files Coverage Δ
src/arti/internal/__init__.py 100.00% <ø> (ø)
src/arti/__init__.py 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@JacobHayes JacobHayes merged commit e70c710 into golden Jul 19, 2022
@JacobHayes JacobHayes deleted the move-version branch July 19, 2022 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants