Skip to content

Comments

Add pyarrow TypeSystem#234

Merged
JacobHayes merged 1 commit intoartigraph:goldenfrom
kaelgreco:pyarrow-type
Jun 16, 2022
Merged

Add pyarrow TypeSystem#234
JacobHayes merged 1 commit intoartigraph:goldenfrom
kaelgreco:pyarrow-type

Conversation

@kaelgreco
Copy link
Contributor

@kaelgreco kaelgreco commented Jun 15, 2022 •
edited by JacobHayes
Loading

Description

Add pyarrow TypeSystem.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added tests.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in upstream modules

@kaelgreco kaelgreco requested a review from JacobHayes as a code owner June 15, 2022 22:08
@JacobHayes JacobHayes changed the title Add pyarrow type system Add pyarrow TypeSystem Jun 15, 2022
@JacobHayes
Copy link
Member

JacobHayes commented Jun 15, 2022 •
edited
Loading

Awesome, thanks for adding @kaelgreco! I'm gonna merge in golden to fix the poetry.toml conflict and then may push a couple other tweaks.

@JacobHayes JacobHayes self-assigned this Jun 16, 2022
JacobHayes
JacobHayes approved these changes Jun 16, 2022
View reviewed changes
Copy link
Member

@JacobHayes JacobHayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is in a good state! Something funny is going on with CI, will try to figure out.

@kaelgreco @bnaul
@JacobHayes @rregue
Add pyarrow TypeSystem
3442f9b 
Co-authored-by: Brett Naul <[email protected]>
Co-authored-by: Jacob Hayes <[email protected]>
Co-authored-by: Robert Regue <[email protected]>
Signed-off-by: Jacob Hayes <[email protected]>
Signed-off-by: Kael Greco <[email protected]>
@JacobHayes
Copy link
Member

JacobHayes commented Jun 16, 2022

I'll have to figure out the CI not running later, I think it may have to do with running from a fork, but I don't see the "Approve and run" (perhaps the DCO app running immediately interferes with it somehow?)

@JacobHayes JacobHayes merged commit 280c71d into artigraph:golden Jun 16, 2022
@JacobHayes JacobHayes mentioned this pull request Jul 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JacobHayes JacobHayes JacobHayes approved these changes

Assignees

@JacobHayes JacobHayes

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kaelgreco @JacobHayes