Skip to content

Comments

Add Graph.build and lots of other changes#133

Merged
JacobHayes merged 33 commits intogoldenfrom
graph-build
Nov 30, 2021
Merged

Add Graph.build and lots of other changes#133
JacobHayes merged 33 commits intogoldenfrom
graph-build

Conversation

@JacobHayes
Copy link
Member

May try to split up (or just merge 🤷), but finally had a chance to finish up the Graph.build logic, iron out the last (known) bugs, and complete test coverage. Just throwing out for now.

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #133 (63fc1a0) into golden (ae6395a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            golden      #133    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           26        34     +8     
  Lines         1394      1986   +592     
  Branches       285       427   +142     
==========================================
+ Hits          1394      1986   +592     
Impacted Files Coverage Δ
src/arti/versions/__init__.py 100.00% <ø> (ø)
src/arti/__init__.py 100.00% <100.00%> (ø)
src/arti/artifacts/__init__.py 100.00% <100.00%> (ø)
src/arti/backends/__init__.py 100.00% <100.00%> (ø)
src/arti/backends/memory.py 100.00% <100.00%> (ø)
src/arti/executors/__init__.py 100.00% <100.00%> (ø)
src/arti/executors/local.py 100.00% <100.00%> (ø)
src/arti/fingerprints/__init__.py 100.00% <100.00%> (ø)
src/arti/formats/__init__.py 100.00% <100.00%> (ø)
src/arti/formats/json.py 100.00% <100.00%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae6395a...63fc1a0. Read the comment docs.

- Move partition/cluster spec from Struct to List
- Replace Artifact.singular with explicit List type
- Expose partitioning info from Artifacts
@JacobHayes JacobHayes merged commit 76d8069 into golden Nov 30, 2021
@JacobHayes JacobHayes deleted the graph-build branch November 30, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant