Apply isort/black formatting in pre-commit (pytest only checks)#13
Merged
JacobHayes merged 1 commit intogoldenfrom Mar 16, 2021
Merged
Apply isort/black formatting in pre-commit (pytest only checks)#13JacobHayes merged 1 commit intogoldenfrom
JacobHayes merged 1 commit intogoldenfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## golden #13 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 2 2
=========================================
Hits 2 2 Continue to review full report at Codecov.
|
JacobHayes
force-pushed
the
format-in-precommit
branch
from
7258c2a to
815ef33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pre-commit pytest run only checks the files for isort/black diff but doesn't apply the changes, meaning devs have to apply/run manually after. By running them first in pre-commit, the dev now only has to
git addthe changes.