CI Multiple Python Versions and py 3.10 support#116
Merged
JacobHayes merged 7 commits intogoldenfrom Nov 17, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## golden #116 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 26 26
Lines 1416 1394 -22
Branches 196 196
=========================================
- Hits 1416 1394 -22
Continue to review full report at Codecov.
|
JacobHayes
force-pushed
the
ci-new-python
branch
from
4320ddb to
3268fd4
Compare
JacobHayes
force-pushed
the
ci-new-python
branch
from
3268fd4 to
ea55e62
Compare
JacobHayes
force-pushed
the
ci-new-python
branch
from
ea55e62 to
fe3997e
Compare
JacobHayes
changed the title
JacobHayes
commented
Nov 17, 2021
Member
Author
JacobHayes
left a comment
JacobHayes
left a comment
There was a problem hiding this comment.
Gonna merge, but feel free to review if interested. 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pydantic has some issues with string
ClassVars in py 3.9.8 (which bumped automatically for new CI runs) and 3.10. For now, I pinned CI to only require 3.9.7, but add 3.9.8 and 3.10.0 to the CI matrix. Hopefully the associated PR will be merged and prompt a pydantic release soon enough, but if not we can remove thefrom __future__ import annotationsand stringize only when necessary (mostly forward refs/cyclic imports).(I blindly pushed f567b38 directly to
golden, but this PR fixes a few issues w/ that)